Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: textDocument/rename support #4

Closed
wants to merge 2 commits into from
Closed

feat: textDocument/rename support #4

wants to merge 2 commits into from

Conversation

Nybkox
Copy link
Contributor

@Nybkox Nybkox commented Feb 4, 2024 •
edited
Loading

It seems to be a long-awaited missing feature.

  1. Should it be configurable?
  2. Should it be disabled in visual mode?

@gregorias
Copy link
Owner

Hi, thanks for prodding this.

Before this finds a way to main, I’d like to have a few things:

  1. Refactor code to make it configurable. It looks to me like another concept, e.g., transformation mode next to selection mode is in order. Users would then be able to configure whether they want to have it and in which selection mode.
  2. I’d like to have proper tests for it.

I’ll take care of it.

@gregorias
Copy link
Owner

This feature is now done.

@gregorias gregorias closed this Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nybkox @gregorias